Improve exception handling around init/loading of enkf nodes #4970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `util_file_readable` does not function as expected, checking only if a file is readable by its owner. We replace by our own check.
There is a block of code in the forward_model_ok callback that was not covered by tests. We rectify this here.
…_KW parsing errors log! two for the price of one! genous!! fixup
Codecov Report
@@ Coverage Diff @@
## main #4970 +/- ##
==========================================
+ Coverage 63.03% 63.25% +0.21%
==========================================
Files 438 439 +1
Lines 30683 30766 +83
Branches 3127 3176 +49
==========================================
+ Hits 19341 19460 +119
+ Misses 10551 10498 -53
- Partials 791 808 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Is this still being worked on? |
|
We decided to only merge the tests that are part of this PR, and that happened in #4983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #4900
Approach
See commit messages.
See also #4938 (which was closed due to branch on equinor fork) for more context / review history
Pre review checklist