router: make shadow requests inherit parent sampling decision by default #37874
+101
−6
CI (Envoy) / Mobile/TSAN
skipped
Jan 8, 2025 in 0s
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/37874/main@bacb67b)
bacb67b 
#37874 merge main@2425431
router: make shadow requests inherit parent sampling decision by default
Description
This PR changes the behavior of shadow request sampling so that if trace sampling is not explicitly configured in the shadow policy, the shadow request will inherit the parent's sampling decision.
After this change, sampling will follow the trace sampling policy of the original request, which prevents oversampling when runtime sampling is disabled.
Fixes: #37766
Commit Message: router: make shadow requests inherit parent sampling decision by default
Additional Description:
Risk Level: Low
Testing: Added Unit Tests
Docs Changes: Added
Release Notes: Added
Environment
Request variables
| Key | Value |
|---|---|
| ref | 1070f96 |
| sha | bacb67b |
| pr | 37874 |
| base-sha | 2425431 |
| actor | @agrawroh |
| message | router: make shadow requests inherit parent sampling decision by default... |
| started | 1736340528.648285 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:d2be0c198feda0c607fa33209da01bf737ef373f |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-d2be0c198feda0c607fa33209da01bf737ef373f |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 33 |
| patch | 0 |
| dev | true |
Loading