-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
router: make shadow requests inherit parent sampling decision by default #37874
base: main
Are you sure you want to change the base?
Conversation
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Rohit Agrawal <[email protected]>
8202984
to
f5e545a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for take this. And some comments are added to start the work.
/wait |
Signed-off-by: Rohit Agrawal <[email protected]>
Signed-off-by: Rohit Agrawal <[email protected]>
Signed-off-by: Rohit Agrawal <[email protected]>
@wbpcode Not sure if this is something that is normally allowed but I work with @samschlegel (original issue reporter) and while this change is undoubtably useful for everyone as implemented, unfortunately the xDS control plane we are using (GCP Traffic Director) hardcodes the shadow policy's trace_sampled to As a workaround in the meantime, would it be possible to add a second runtime flag to basically "force" ignoring the shadow policy's trace_sampled config (so essentially an extra Totally understand if the answer is "no" given we have a unique use case here with our control plane choice, but figured I would get a pulse on whether it could be considered :) |
Description
This PR changes the behavior of shadow request sampling so that if trace sampling is not explicitly configured in the shadow policy, the shadow request will inherit the parent's sampling decision.
After this change, sampling will follow the trace sampling policy of the original request, which prevents oversampling when runtime sampling is disabled.
Fixes: #37766
Commit Message: router: make shadow requests inherit parent sampling decision by default
Additional Description:
Risk Level: Low
Testing: Added Unit Tests
Docs Changes: Added
Release Notes: Added