Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter icon change #522

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Twitter icon change #522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c910b1
Twitter icon change
nitesh2920 Oct 9, 2024
2718b08
twiiter updated
nitesh2920 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/constants/es-footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const socialLinks = [{
title: 'Twitter',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we not also change the title?

Copy link
Author

@nitesh2920 nitesh2920 Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay , I will change the title from Twitter to X.

href: 'http://twitter.com/emberjs',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're changing the logo then shouldn't we be linking to x.com/emberjs ?

Copy link
Author

@nitesh2920 nitesh2920 Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I will change it.

class: 'twitter-logo',
class: 'x-logo',
label: 'Official Ember Twitter Account'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're changing the logo we should probably change Twitter here too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I got your point to replace twitter to X , is there anything more ?
does need to change label also ?

}, {
title: 'GitHub',
Expand Down
4 changes: 2 additions & 2 deletions addon/constants/icons.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.