Twitter icon change #522
Twitter icon change #522
Conversation
❌ Deploy Preview for ember-styleguide failed.
|
addon/constants/es-footer.js
Outdated
| @@ -3,7 +3,7 @@ | |||
| const socialLinks = [{ | |||
| title: 'Twitter', | |||
There was a problem hiding this comment.
would we not also change the title?
There was a problem hiding this comment.
Okay , I will change the title from Twitter to X.
addon/constants/es-footer.js
Outdated
| @@ -3,7 +3,7 @@ | |||
| const socialLinks = [{ | |||
| title: 'Twitter', | |||
| href: 'http://twitter.com/emberjs', | |||
There was a problem hiding this comment.
If we're changing the logo then shouldn't we be linking to x.com/emberjs ?
addon/constants/es-footer.js
Outdated
| @@ -3,7 +3,7 @@ | |||
| const socialLinks = [{ | |||
| title: 'Twitter', | |||
| href: 'http://twitter.com/emberjs', | |||
| class: 'twitter-logo', | |||
| class: 'x-logo', | |||
| label: 'Official Ember Twitter Account' | |||
There was a problem hiding this comment.
If we're changing the logo we should probably change Twitter here too
There was a problem hiding this comment.
okay I got your point to replace twitter to X , is there anything more ?
does need to change label also ?
|
@mansona made the required changes please review it. |
|
From what I can see this looks good, I just don't feel comfortable merging this until I fix the issues with CI. I'll try to take a look tomorrow 👍 |
|
@mansona Thanks for the update! Looking forward to your feedback tomorrow! |
|
@mansona any update on this ? |
I've updated the Twitter logo to the new logo