Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write missing deprecation guides #893

Open
locks opened this issue Jul 3, 2021 · 10 comments
Open

Write missing deprecation guides #893

locks opened this issue Jul 3, 2021 · 10 comments
Assignees

Comments

@locks
Copy link
Contributor

locks commented Jul 3, 2021

Hi everyone!

We noticed some missing deprecation guides when doing housekeeping in preparation for 4.0.
Assign yourself one of the deprecations below and let's get this done :)

What to do

  • Add a new deprecation. You can consult the relevant RFC to get a good idea of what the guide should contain.
  • Update the relevant source code (also linked below) with a link to the deprecation. You can get a deprecation link using the netlify preview. Asks us if you need help!
  • Boom, you're done!

Deprecations

Ember.Component.reopen

Passing tagName to LinkTo

Passing disabledWhen to LinkTo

Old deprecate method imports

Deprecate without for

Deprecate without since

EXTEND_PROTOTYPES

Class-based template compilation plugins

@locks locks changed the title Missing deprecation guides Write missing deprecation guides Jul 3, 2021
@ef4
Copy link
Contributor

ef4 commented Jul 8, 2021

I think also deprecated-run-loop-and-computed-dot-access.

@chancancode
Copy link
Contributor

That’s correct. In practice it can probably share most of the prose with that globals deprecation, you mostly experience that as a special case of the globals access deprecation

@Glarregle
Copy link
Contributor

I will work on the following:

Ember.Component.reopen
Passing tagName to LinkTo
Passing disabledWhen to LinkTo
Old deprecate method imports

@ijlee2
Copy link
Member

ijlee2 commented Sep 6, 2021

@Glarregle Awesome, thank you!

@jenweber
Copy link
Contributor

jenweber commented Sep 8, 2021

I have a PR open that creates placeholder files for all these deprecations. We still need volunteers to fill in all the details in each deprecation guide. See #954

@Glarregle if my PR is merged before yours, please feel free to delete any of my descriptions and fill them with your own writeup. All I did was make the files and copy-paste the deprecation message into them, and we want to provide better guidance than what I copied in. Thank you!

@jenweber
Copy link
Contributor

jenweber commented Sep 8, 2021

@Glarregle I discovered that the tagName deprecation already exists: https://deprecations.emberjs.com/v3.x/#toc_ember-built-in-components-legacy-arguments so this one does not need a new writeup.

@bartocc
Copy link
Contributor

bartocc commented Sep 21, 2021

Hi, @fannyvanrell and myself would like to work on EXTEND_PROTOTYPES if that's still needed.

cc: @MonsieurDart @pbernery

@ijlee2
Copy link
Member

ijlee2 commented Sep 21, 2021

@bartocc @fannyvanrell Thank you, I think we do need help with providing details for https://deprecations.emberjs.com/v3.x#toc_ember-env-old-extend-prototypes.

Can you also fix the typo in the h3 header? protptypes should read prototypes.

Old extend prototypes

@bartocc
Copy link
Contributor

bartocc commented Oct 14, 2021

Hi again. We'd like to go for Deprecate without for and Deprecate without since if that's OK.
cc @fannyvanrell

@ijlee2
Copy link
Member

ijlee2 commented Oct 14, 2021

@bartocc @fannyvanrell I updated the description to list your names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants