Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation guide Ember.link-to @disabled-when #955

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Deprecation guide Ember.link-to @disabled-when #955

merged 1 commit into from
Oct 1, 2021

Conversation

Glarregle
Copy link
Contributor

@Glarregle Glarregle commented Sep 8, 2021 •
edited
Loading

Progress #893

@Glarregle Glarregle changed the title Deprecate Ember.link-to @disabled-when Deprecation guide Ember.link-to @disabled-when Sep 8, 2021
@Glarregle Glarregle mentioned this pull request Sep 8, 2021
Merged
locks
locks reviewed Sep 13, 2021
View reviewed changes
app/routes/show.js Outdated Show resolved Hide resolved
locks
locks approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

@locks locks merged commit edd60bb into ember-learn:main Oct 1, 2021
@bertdeblock
Copy link
Contributor

Sorry to comment on a merged PR, but it seems the until value used here is not the same as for the actual deprecation: https://github.com/emberjs/ember.js/blob/57907a4d7d91aa58b3b3ac1258e639ce221f9492/packages/@ember/-internals/glimmer/lib/components/link-to.ts#L635.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locks locks locks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Glarregle @bertdeblock @locks