-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub out deprecation files #954
Conversation
@locks do you know what the version numbers should be, if the "since" was never filled in? Should some of these deprecations be in the 3.x folder instead, or should I just label them all |
I don't think any of them are v4 deprecations, but let's discuss together in the call! |
content/ember/v4/link-to-tag-name.md
Outdated
until: '5.0.0' | ||
since: '4.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be deleted. We already have an entry: https://deprecations.emberjs.com/v3.x#toc_ember-built-in-components-legacy-arguments
And a PR: emberjs/ember.js#19747
until: '5.0.0' | ||
since: '4.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should these versions be? See PR emberjs/ember.js#19748 and emberjs/ember.js#19748
To-do:
Followup steps:
|
We need to create these files ASAP so that the source code has something to link to. It was discussed & planned at the last learning team meeting that we would create and ship placeholder files ASAP.
We still need volunteers to fill in the actual content. For the files that have a writeup, it's just copy-pasted from the deprecation message, and we need to give more guidance than that.
If you can help out, please see #893 Thank you!