Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub out deprecation files #954

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Stub out deprecation files #954

merged 4 commits into from
Sep 13, 2021

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Sep 8, 2021

We need to create these files ASAP so that the source code has something to link to. It was discussed & planned at the last learning team meeting that we would create and ship placeholder files ASAP.

We still need volunteers to fill in the actual content. For the files that have a writeup, it's just copy-pasted from the deprecation message, and we need to give more guidance than that.

If you can help out, please see #893 Thank you!

@jenweber
Copy link
Contributor Author

jenweber commented Sep 8, 2021

@locks do you know what the version numbers should be, if the "since" was never filled in? Should some of these deprecations be in the 3.x folder instead, or should I just label them all since: 4.0.0?

@jenweber jenweber requested review from mansona and locks September 8, 2021 01:41
@locks
Copy link
Contributor

locks commented Sep 9, 2021

I don't think any of them are v4 deprecations, but let's discuss together in the call!

Comment on lines 4 to 5
until: '5.0.0'
since: '4.0.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +4 to +5
until: '5.0.0'
since: '4.0.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should these versions be? See PR emberjs/ember.js#19748 and emberjs/ember.js#19748

@jenweber
Copy link
Contributor Author

jenweber commented Sep 9, 2021

To-do:

  • Remove files for entries that already have PRs
  • Apply the version updates
  • Add a link to the WIP entries inviting people to help edit
  • Put in a sentence here & there if I can find one

Followup steps:

  • Ask the deprecation contributor/RFC author if they will help write these. Share the context that deprecation guides are supposed to be written before releases finish.

@locks locks enabled auto-merge September 13, 2021 15:31
@locks locks merged commit dcac852 into main Sep 13, 2021
@locks locks deleted the jw-v4-placeholders branch September 13, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants