Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowClone: Fix invisible if shown while Multitasking view is open #2152

Merged
merged 2 commits into from
Dec 12, 2024
Merged

WindowClone: Fix invisible if shown while Multitasking view is open #2152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
307cece
WindowClone: Fix invisible if shown while Multitasking view is open
leolost2605 Dec 10, 2024
13bf5e3
Merge branch 'main' into leolost/fix-window-shown-multitasking-view
lenemter Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions src/Widgets/WindowClone.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public class Gala.WindowClone : Clutter.Actor {
window.notify["fullscreen"].connect (check_shadow_requirements);
window.notify["maximized-horizontally"].connect (check_shadow_requirements);
window.notify["maximized-vertically"].connect (check_shadow_requirements);
window.size_changed.connect (() => request_reposition ());

if (overview_mode) {
var click_action = new Clutter.ClickAction ();
Expand Down Expand Up @@ -183,16 +184,14 @@ public class Gala.WindowClone : Clutter.Actor {
* at this point it will animate to it. Otherwise it will just place
* itself at the location of the original window. Also adds the shadow
* effect and makes sure the shadow is updated on size changes.
*
* @param was_waiting Internal argument used to indicate that we had to
* wait before the window's texture became available.
*/
private void load_clone (bool was_waiting = false) {
private void load_clone () {
var actor = (Meta.WindowActor) window.get_compositor_private ();
if (actor == null) {
Idle.add (() => {
if (window.get_compositor_private () != null)
load_clone (true);
if (window.get_compositor_private () != null) {
load_clone ();
}
return Source.REMOVE;
});

Expand All @@ -217,18 +216,6 @@ public class Gala.WindowClone : Clutter.Actor {
if (should_fade ()) {
opacity = 0;
}

// if we were waiting the view was most probably already opened when our window
// finally got available. So we fade-in and make sure we took the took place.
// If the slot is not available however, the view was probably closed while this
// window was opened, so we stay at our old place.
if (was_waiting && slot != null) {
opacity = 0;
take_slot (slot, true);
opacity = 255;

request_reposition ();
}
}

private void check_shadow_requirements () {
Expand Down
Loading