Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowClone: Fix invisible if shown while Multitasking view is open #2152

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Dec 10, 2024

We now just connect to size changed signal and request reposition which we should be doing anyway. The stuff we did previously won't work on wayland because we don't have a window size and position yet when the actor becomes available so the given slot is nonsensical.

This brings no change for X neither compared to main nor to pre #2082 but fixes it for wayland.

Fixes #857

@leolost2605 leolost2605 requested a review from a team December 10, 2024 14:48
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and fixes the linked issue. Good job

@lenemter lenemter merged commit c164204 into main Dec 12, 2024
5 checks passed
@lenemter lenemter deleted the leolost/fix-window-shown-multitasking-view branch December 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling the active window's maximization state during multitasking view messes up the window preview size
2 participants