Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yaml #1781

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Conversation

LeonAlvarez
Copy link
Contributor

With current docker-compose without ssl mode enabled, electric wont connect to local postgresql started by docker-compose. This PR disable sslmode in the url

 [warning]  Database connection in lock_connection mode failed: ssl not available

Fix issue with ssl mode
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit d5adf61
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/66fd11ac91067500081e12c9
😎 Deploy Preview https://deploy-preview-1781--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Disable ssl mode in demos
@KyleAMathews
Copy link
Contributor

Huh interesting. I haven't seen this issue. What's your os? I'm on Mac.

@LeonAlvarez
Copy link
Contributor Author

LeonAlvarez commented Oct 2, 2024

I'm on mac too. Someone else was also reporting this on dc. So thought might be good to do the PR maybe you have something to automatically set ssl? like some magic-dns

@alco
Copy link
Member

alco commented Oct 3, 2024

This didn't use to be required until very recently, it's a new regression. I have detailed the problem in #1792.

Once it is fixed, you won't be required to include sslmode=disable in DATABASE_URL as before.

@KyleAMathews
Copy link
Contributor

I'm just going to merge this for now as otherwise people are failing. @alco please revert once you've got your fix in.

@KyleAMathews KyleAMathews merged commit 1bf3077 into electric-sql:main Oct 6, 2024
14 of 15 checks passed
KyleAMathews pushed a commit that referenced this pull request Nov 1, 2024
With current docker-compose without ssl mode enabled, electric wont
connect to local postgresql started by docker-compose. This PR disable
sslmode in the url

```
 [warning]  Database connection in lock_connection mode failed: ssl not available
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants