Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electric no longer performs automatic fallback to disabling SSL for database connections #1792

Closed
alco opened this issue Oct 3, 2024 · 1 comment · Fixed by #2084
Closed
Assignees
Labels

Comments

@alco
Copy link
Member

alco commented Oct 3, 2024

Prior to #1762, Electric tried to connect to the database using SSL first, then fall back to using an unencrypted connection unless the DATABASE_URL config had the sslmode query parameter in it.

#1762 made changes to the DB connection setup and, as an accidental side effect, Electric no longer performs the automatic fallback. I believe this wouldn't have happened if the fallback logic hadn't been moved from ConnectionManager to ReplicationClient in #1594.

To fix this regression, we need to move the fallback logic back to ConnectionManager and add an integration test to preclude future regressions.

@balegas
Copy link
Contributor

balegas commented Oct 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants