fix(sync-service): Query Postgres server version at the start of connection setup #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were querying it after starting the replication client before, which was too late, because by that time the shape recovery process might have already reached Electric.Postgres.Configuration.configure_tables_for_replication!() where the version is used to branch the control flow. The choice of augmenting the LockConnection module with version querying and a crude state machine might seem dubious but the end result is simpler this way, compared to adding version querying to the replication client, for example.
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alco
force-pushed
the
alco/pg-version-query-race
branch
from
442c827 to
f99ad93
Compare
msfstef
approved these changes
Oct 3, 2024
kevin-dp
approved these changes
Oct 3, 2024
KyleAMathews
pushed a commit
that referenced
this pull request
Nov 1, 2024
…ection setup (#1784) We were querying it after starting the replication client before, which was too late, because by that time the shape recovery process might have already reached `Electric.Postgres.Configuration.configure_tables_for_replication!()` where the version is used to branch the control flow. This was causing flake in integration tests due to the version not always being there and the unsupported query being issue against Postgres version 14. In short, this PR resolves the flakiness in integration tests, they should be consistently green from now on. The choice of augmenting the `LockConnection` module with version querying and a crude state machine might seem dubious but the end result is simpler this way, compared to adding version querying to the replication client, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were querying it after starting the replication client before, which was too late, because by that time the shape recovery process might have already reached
Electric.Postgres.Configuration.configure_tables_for_replication!()where the version is used to branch the control flow. This was causing flake in integration tests due to the version not always being there and the unsupported query being issue against Postgres version 14.In short, this PR resolves the flakiness in integration tests, they should be consistently green from now on.
The choice of augmenting the
LockConnectionmodule with version querying and a crude state machine might seem dubious but the end result is simpler this way, compared to adding version querying to the replication client, for example.