feat(bug) : Releases attachment download issue fix #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keerthi-bl
changed the title
keerthi-bl
changed the title
keerthi-bl
changed the title
|
Test successful.
|
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/release/ReleaseController.java
Show resolved
Hide resolved
...rce-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/ReleaseSpecTest.java
Show resolved
Hide resolved
| subsectionWithPath("_embedded.sw360:attachments.[]createdTeam").description("The attachment created team value"), | ||
| subsectionWithPath("_embedded.sw360:attachments.[]createdOn").description("The attachment created on value"), | ||
| subsectionWithPath("_embedded.sw360:attachments.[]checkStatus").description("The attachment checkStatus value"), | ||
| subsectionWithPath("_embedded.sw360:attachments.[]createdOn").description("The attachment checkedComment value"), |
There was a problem hiding this comment.
it should be []checkedComment according to the description.
...rce-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/ReleaseSpecTest.java
Show resolved
Hide resolved
Signed-off-by: Keerthi B L <[email protected]>
keerthi-bl
force-pushed
the
fix/AttachmentDownloadIssueFix
branch
from
6f49d28
to
ec750b8
Compare
|
Code looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2136
Suggest Reviewer
How To Test?
URL : http://localhost:8080/resource/api/releases/caf6ff2180064d9faaebe8d7a7cd5ae2/attachments
Sample Response in the following attachment :
Checklist
Must: