Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Rest) : Releases attachment download is failing #2136

Open
keerthi-bl opened this issue Oct 5, 2023 · 6 comments
Open

feat(Rest) : Releases attachment download is failing #2136

keerthi-bl opened this issue Oct 5, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@keerthi-bl
Copy link
Contributor

keerthi-bl commented Oct 5, 2023

Description

Download attachment is not working with rest end point.

Response structure has changed from "_embedded" : { "sw360:attachments" : [] } to {'_embedded': {'sw360:attachmentDTOes': […

Screenshots

If applicable, add screenshots to help explain your problem.

Versions

  • Last commit id on master:
  • Operating System (lsb_release -a):

Logs

Any logs (if any) generated in

SW360 logs

Logs generated under /var/log/sw360/sw360.log

Tomcat logs

Logs generated under /var/log/tomcat/error.log

@keerthi-bl keerthi-bl added the bug Something isn't working label Oct 5, 2023
@tuannn2
Copy link
Contributor

tuannn2 commented Oct 5, 2023

Hi @keerthi-bl,
I am using sw360 in branch Main (4666d87).
I'm still using the donwload attachment functionality for projects, components, releases normally.

May I know which Endpoint you are using?

@keerthi-bl
Copy link
Contributor Author

Hi @tuannn2 ,
Some response structure has been changed with the rest end point while fetching release attachment info.
Previously it was,
"_embedded" : { "sw360:attachments" : [] } like this.
It has been changed to ,
{'_embedded': {'sw360:attachmentDTOes': [… like this.
This may break when we are trying to fetch with attachments key. This issue is to revert to previous version/code.

@tuannn2
Copy link
Contributor

tuannn2 commented Oct 6, 2023

Hi @keerthi-bl,
Can you change title issues? Because features Download attachment is working normally.

  • On response structure has been changed to add field response detail for Listing Attachment Information for Release, Component page in sw360-frontend

Is this change necessary?

@keerthi-bl keerthi-bl changed the title feat(Rest) : Download attachment is not working feat(Rest) : Downloading release attachment is failing Oct 6, 2023
@keerthi-bl keerthi-bl changed the title feat(Rest) : Downloading release attachment is failing feat(Rest) : Releases attachment download is failing Oct 9, 2023
@ag4ums
Copy link
Contributor

ag4ums commented Dec 13, 2023

@keerthi-bl, please create PR with the reverted changes

@keerthi-bl
Copy link
Contributor Author

#2140 is the PR @ag4ums , already merged. Need to close this issue only.

@keerthi-bl
Copy link
Contributor Author

Hi @tuannn2 :
The end point is not failing actually.

{.** On response structure has been changed to add field response detail for Listing Attachment Information for Release, Component page in sw360-frontend}**

Its failing to the client who are accepting the key as attachments from the end point . So the above changes affect other clients who are using this end point. So its necessary to revert the changes.

Please confirm, can we close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants