Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1116 Revise model loading #211

Merged
merged 3 commits into from
Sep 15, 2023
Merged

GLSP-1116 Revise model loading #211

merged 3 commits into from
Sep 15, 2023

Commits on Sep 14, 2023

  1. GLSP-1116 Revise model loading

    - Refactor `ModelSubmissionHandler` to support proper handling of the `RequestModelAction`
    as real request action 
    - Add support for rejecting request actions
    Part-of: eclipse-glsp/glsp#1116
    Part-of: eclipse-glsp/glsp#606
    tortmayr committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    0b1e144 View commit details
    Browse the repository at this point in the history
  2. GLSP-1117: Remove need for explicit definition of client actions

    Refactor the base GLSP protocol to allow the client to tell the server which actions it is going to handle i.e. which actions should be forwarded to the client
    - Add `clientActions` array to `InitializeClientSessionParams`. This means the client now has to pass the action kinds it wants to handle as part of the initalize request
    - Refactor `ClientSessionManager` API directly use the `InitializeClientSessionParams` object for creating new sessions. This means that the `ClientSessionManager` can also access the generic `args` properties that might have been passed with the initialize request.
    - Replace `ClientActionHandler` with `ClientActionForwader` a separate component that is not part of the server-side action handlers. 
    - Remove `configureClientActions` method from `DiagramModule` as the explicit configuration is no longer needed
    - Refactor `ClientIdModule` to `ClietnSessionModule` responsible for injection session specific configuration like the clientId and the clientActions
    
    Part of eclipse-glsp/glsp/issues/1117
    tortmayr committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    be1e3fb View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. GLSP-1071: Rename ServerStatus/ServerMessage action

    Also remove unused `ServerStatus` class
    Part of eclipse-glsp/glsp#1071
    tortmayr committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    d3439e7 View commit details
    Browse the repository at this point in the history