GLSP-1116 Revise model loading #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planger
approved these changes
Sep 12, 2023
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/RejectAction.java
Outdated
Show resolved
Hide resolved
...ipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/ModelSubmissionHandler.java
Outdated
Show resolved
Hide resolved
...ipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/ModelSubmissionHandler.java
Outdated
Show resolved
Hide resolved
...ipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/ModelSubmissionHandler.java
Outdated
Show resolved
Hide resolved
...ipse.glsp.server/src/org/eclipse/glsp/server/features/core/model/ModelSubmissionHandler.java
Outdated
Show resolved
Hide resolved
|
@planger I have also added change for GLSP-1117 and GLSP-1071 to this PR. Since these are also changes that require updatse across all integration projects I would rather do this all in one go instead of having to create multiple PRs per repository. Could you please re-review? |
- Refactor `ModelSubmissionHandler` to support proper handling of the `RequestModelAction` as real request action - Add support for rejecting request actions Part-of: eclipse-glsp/glsp#1116 Part-of: eclipse-glsp/glsp#606
Refactor the base GLSP protocol to allow the client to tell the server which actions it is going to handle i.e. which actions should be forwarded to the client - Add `clientActions` array to `InitializeClientSessionParams`. This means the client now has to pass the action kinds it wants to handle as part of the initalize request - Refactor `ClientSessionManager` API directly use the `InitializeClientSessionParams` object for creating new sessions. This means that the `ClientSessionManager` can also access the generic `args` properties that might have been passed with the initialize request. - Replace `ClientActionHandler` with `ClientActionForwader` a separate component that is not part of the server-side action handlers. - Remove `configureClientActions` method from `DiagramModule` as the explicit configuration is no longer needed - Refactor `ClientIdModule` to `ClietnSessionModule` responsible for injection session specific configuration like the clientId and the clientActions Part of eclipse-glsp/glsp/issues/1117
Also remove unused `ServerStatus` class Part of eclipse-glsp/glsp#1071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLSP-1116 Revise model loading
ModelSubmissionHandlerto support proper handling of theRequestModelActionas real request actionPart-of: Model initialization behavior is flaky glsp#1116
Part-of: Add server side support for rejecting actions glsp#606
GLSP-1117: Remove need for explicit definition of client actions
Refactor the base GLSP protocol to allow the client to tell the server which actions it is going to handle i.e. which actions should be forwarded to the client
clientActionsarray toInitializeClientSessionParams. This means the client now has to pass the action kinds it wants to handle as part of the initalize requestClientSessionManagerAPI directly use theInitializeClientSessionParamsobject for creating new sessions. This means that theClientSessionManagercan also access the genericargsproperties that might have been passed with the initialize request.ClientActionHandlerwithClientActionForwadera separate component that is not part of the server-side action handlers.configureClientActionsmethod fromDiagramModuleas the explicit configuration is no longer neededClientIdModuletoClietnSessionModuleresponsible for injection session specific configuration like the clientId and the clientActionsPart of eclipse-glsp/glsp/issues/1117
GLSP-1071: Rename ServerStatus/ServerMessage action
Also remove unused
ServerStatusclassPart of eclipse-glsp/glsp#1071