Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-Party Plugin Support Deprecation Warning #265

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

firthm01
Copy link
Contributor

@firthm01 firthm01 commented Jan 2, 2024

Warns user that support for third-party plugin suites will be dropped in future versions. Message is shown when the user imports ADM using a third-party plugin suite in to a new project or in to an existing project. Warning also shows in the render dialog when "ADM" output format is selected and instances of the ADM Export Source VST are found.

This has been mainly implemented in it's own header so we can easily strip it out and make sure we don't leave anything behind (compiler will point out all the affected bits of code once the header is deleted).

@firthm01 firthm01 self-assigned this Jan 2, 2024
@firthm01 firthm01 changed the base branch from main to supplementary-definitions January 2, 2024 13:51
Copy link
Contributor

@rsjbailey rsjbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from supplementary-definitions to main February 29, 2024 14:59
@firthm01 firthm01 merged commit b5026c6 into main Feb 29, 2024
5 checks passed
@firthm01 firthm01 deleted the plugin-deprecation-warning branch February 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants