Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.1 feature branches combined #271

Closed
wants to merge 191 commits into from
Closed

Conversation

firthm01
Copy link
Contributor

Working towards removing the horrible hard-coded speaker setups and using indexes to refer to them
Just for consistency with what we will do for DS - we don't need a separate instance, just the singleton
WIP - will not compile at this stage
WIP - will not compile at this stage

Uses a pack format ID between the DS plugin and the scene (similar to how HOA handles it)
…out index

WIP - will not compile at this stage
... instead of speaker layout obj

WIP - will not compile at this stage
WIP - will not compile at this stage
WIP - will compile, but tests failing
rsjbailey and others added 23 commits February 26, 2024 19:39
…tore

Using map allows lookup by file and keeps them sorted
As DataFile is POD and small, using value semantics is simpler
It's not a library, we all have recent compilers.
Was overridden for this individual plugin for some reason
Fixes C2440 'initializing': cannot convert from 'const char [x]' to 'char *' with msvc
User should select replacement - draws attention to the fact their previous preference is no longer available.
Removed output chns also - we're not manipulating audio so we don't need to specify them.
When stripping out, just delete the header and see what the compiler throws up.
@firthm01 firthm01 self-assigned this Feb 26, 2024
@firthm01
Copy link
Contributor Author

Previous 3 "fix" commits cherry-picked in to relevant branches

Up to date at this point.

@firthm01
Copy link
Contributor Author

All branches independently merged in to main

@firthm01 firthm01 closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants