-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.1 feature branches combined #271
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working towards removing the horrible hard-coded speaker setups and using indexes to refer to them
Just for consistency with what we will do for DS - we don't need a separate instance, just the singleton
WIP - will not compile at this stage
WIP - will not compile at this stage Uses a pack format ID between the DS plugin and the scene (similar to how HOA handles it)
WIP - will not compile at this stage
…out index WIP - will not compile at this stage
... instead of speaker layout obj WIP - will not compile at this stage
WIP - will not compile at this stage
WIP - will compile, but tests failing
…tore Using map allows lookup by file and keeps them sorted As DataFile is POD and small, using value semantics is simpler
It's not a library, we all have recent compilers.
Was overridden for this individual plugin for some reason
Fixes C2440 'initializing': cannot convert from 'const char [x]' to 'char *' with msvc
User should select replacement - draws attention to the fact their previous preference is no longer available.
Removed output chns also - we're not manipulating audio so we don't need to specify them.
When stripping out, just delete the header and see what the compiler throws up.
Previous check always returned true, so was always shown
All branches independently merged in to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of (in order):
This concludes all PRs for v1.1