Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock is blk alloced to fix assert. #310

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

sanebay
Copy link
Contributor

@sanebay sanebay commented Feb 8, 2024

There seems a concurrency issue when is blk alloced fails in test_data_service.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78901af) 47.55% compared to head (9802183) 47.80%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   47.55%   47.80%   +0.25%     
==========================================
  Files         107      107              
  Lines        9280     9275       -5     
  Branches     1203     1200       -3     
==========================================
+ Hits         4413     4434      +21     
+ Misses       4396     4371      -25     
+ Partials      471      470       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanebay sanebay force-pushed the fix_blk_alloc_assert branch from 0bdf000 to 43aad06 Compare February 8, 2024 01:29
@sanebay sanebay requested review from hkadayam and yamingk February 8, 2024 01:51
@yamingk
Copy link
Contributor

yamingk commented Feb 8, 2024

can you bump con ver

There seems a concurrency issue when is blk alloced fails
in test_data_service.
@sanebay sanebay force-pushed the fix_blk_alloc_assert branch from 43aad06 to 9802183 Compare February 8, 2024 19:10
@sanebay sanebay merged commit c8021ab into eBay:master Feb 8, 2024
20 checks passed
@sanebay sanebay deleted the fix_blk_alloc_assert branch February 8, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants