Add lock is blk alloced to fix assert.

There seems a concurrency issue when is blk alloced fails in test_data_service.
eBay · Feb 8, 2024 · 43aad06 · 43aad06
1 parent 78901af
commit 43aad06
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/lib/device/virtual_dev.cpp b/src/lib/device/virtual_dev.cpp
@@ -149,7 +149,7 @@ folly::Future< std::error_code > VirtualDev::async_format() {
 }
 
 bool VirtualDev::is_blk_alloced(BlkId const& blkid) const {
-    return m_dmgr.get_chunk(blkid.chunk_num())->blk_allocator()->is_blk_alloced(blkid);
+    return m_dmgr.get_chunk(blkid.chunk_num())->blk_allocator()->is_blk_alloced(blkid, true /* lock */);
 }
 
 BlkAllocStatus VirtualDev::commit_blk(BlkId const& blkid) {

diff --git a/src/tests/CMakeLists.txt b/src/tests/CMakeLists.txt
@@ -110,7 +110,7 @@ if (${io_tests})
     if(${epoll_tests})
         # add_test(NAME LogStore-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_log_store)
         add_test(NAME MetaBlkMgr-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_meta_blk_mgr)
-        # add_test(NAME DataService-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_data_service)
+        add_test(NAME DataService-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_data_service)
 
         # add_test(NAME SoloReplDev-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_solo_repl_dev)
         # add_test(NAME HomeRaftLogStore-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_home_raft_logstore)