Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pg_id as metrics instance name #168

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Use pg_id as metrics instance name #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class HomeObjectConan(ConanFile):
name = "homeobject"
version = "1.0.15"
version = "1.0.16"
homepage = "https://github.com/eBay/HomeObject"
description = "Blob Store built on HomeReplication"
topics = ("ebay")
Expand Down
2 changes: 1 addition & 1 deletion src/lib/homestore_backend/hs_homeobject.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class HSHomeObject : public HomeObjectImpl {
struct PGMetrics : public sisl::MetricsGroup {
public:
PGMetrics(HS_PG const& pg) :
sisl::MetricsGroup{"PG", boost::uuids::to_string(pg.pg_info_.replica_set_uuid)}, pg_(pg) {
sisl::MetricsGroup{"PG", std::to_string(pg.pg_info_.id)}, pg_(pg) {
// We use replica_set_uuid instead of pg_id for metrics to make it globally unique to allow aggregating
// across multiple nodes
REGISTER_GAUGE(shard_count, "Number of shards");
Expand Down
Loading