Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pg_id as metrics instance name #168

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Use pg_id as metrics instance name #168

merged 1 commit into from
Apr 17, 2024

Conversation

yuwmao
Copy link
Contributor

@yuwmao yuwmao commented Apr 12, 2024

No description provided.

JacksonYao287
JacksonYao287 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can use the only label to show pg id for now, and add uuid back after the support of sisl

@JacksonYao287 JacksonYao287 merged commit de6f3fe into eBay:main Apr 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacksonYao287 JacksonYao287 JacksonYao287 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuwmao @JacksonYao287