Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRAN resubmission fixes #42

Merged
merged 32 commits into from
Aug 20, 2024
Merged

CRAN resubmission fixes #42

merged 32 commits into from
Aug 20, 2024

Commits on Aug 19, 2024

  1. add reference to Corretto license to consent

    @e-kotov
    e-kotov committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    217768f View commit details
    Browse the repository at this point in the history

  2. exclude files from git and build

    @e-kotov
    e-kotov committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b43e066 View commit details
    Browse the repository at this point in the history

  3. update package as per CRAN comments. mostly prevent from writing to u… 

    …ser space
    @e-kotov
    e-kotov committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    167bdfa View commit details
    Browse the repository at this point in the history

  4. exclude md5 files when listing java distribs

    @e-kotov
    e-kotov committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5ca867e View commit details
    Browse the repository at this point in the history

  5. unlink md5 files along with distribs

    @e-kotov
    e-kotov committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ac1fdbb View commit details
    Browse the repository at this point in the history

  6. more param name cleanups

    @e-kotov
    e-kotov committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d4c6b49 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into 2024-08-19-cran-resubmittion

    @e-kotov
    e-kotov committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    af760f0 View commit details
    Browse the repository at this point in the history

  8. implement option for cache folder

    @e-kotov
    e-kotov committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4eaeaa3 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #43 from e-kotov/2024-08-20-cran-resubmission 

    implement option for cache folder
    @e-kotov
    e-kotov authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    188a4ce View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. fix project path handling and printing in java_env_set

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4caddb4 View commit details
    Browse the repository at this point in the history

  2. fix infor regarding the cache path setting in consent boilerplate

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4c511aa View commit details
    Browse the repository at this point in the history

  3. fix cache path output for windows in consent

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    87ff73e View commit details
    Browse the repository at this point in the history

  4. fix bug with nested symlinks on macOS and linux on repeat java_instal… 

    …l runs
    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    256d15d View commit details
    Browse the repository at this point in the history

  5. minor improvements in listing installed java in project dir

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    569852b View commit details
    Browse the repository at this point in the history

  6. create global quiet param help and switch completely to quiet instead… 

    … of verbose
    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    933e7e0 View commit details
    Browse the repository at this point in the history

  7. fix typo in quiet argument in java_install

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    1cc5d3a View commit details
    Browse the repository at this point in the history

  8. fix vignettes for pkgdown

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4776438 View commit details
    Browse the repository at this point in the history

  9. remove rjavaenv folder completely on delte_all=TRUE

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    32031dd View commit details
    Browse the repository at this point in the history

  10. update quick start vignette

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8cc22fe View commit details
    Browse the repository at this point in the history

  11. update the detailed vignette

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    3145382 View commit details
    Browse the repository at this point in the history

  12. cleanup user names

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ba4c02d View commit details
    Browse the repository at this point in the history

  13. fix copy recursion bug

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2db0a94 View commit details
    Browse the repository at this point in the history

  14. fix wording about windows junctions

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    8d003cf View commit details
    Browse the repository at this point in the history

  15. improve docs, examples and messaging

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    17c2de9 View commit details
    Browse the repository at this point in the history

  16. fix temp dir behaviour

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9c91a47 View commit details
    Browse the repository at this point in the history

  17. safer examples with tempdir

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5051e1a View commit details
    Browse the repository at this point in the history

  18. fix cache detection

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0072f45 View commit details
    Browse the repository at this point in the history

  19. fix example in java_install

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6aba6ab View commit details
    Browse the repository at this point in the history

  20. java 17 in quick install example

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c6d4218 View commit details
    Browse the repository at this point in the history

  21. update package metadata

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7983e30 View commit details
    Browse the repository at this point in the history

  22. update readme md

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6707229 View commit details
    Browse the repository at this point in the history

  23. bump patch version and update metadata

    @e-kotov
    e-kotov committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4c76005 View commit details
    Browse the repository at this point in the history