Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRAN resubmission fixes #42

Merged
merged 32 commits into from
Aug 20, 2024
Merged

CRAN resubmission fixes #42

merged 32 commits into from
Aug 20, 2024

Conversation

e-kotov
Copy link
Owner

@e-kotov e-kotov commented Aug 19, 2024

No description provided.

e-kotov and others added 30 commits August 19, 2024 12:31
@e-kotov
add reference to Corretto license to consent
217768f
@e-kotov
exclude files from git and build
b43e066
@e-kotov
update package as per CRAN comments. mostly prevent from writing to u…
167bdfa 
…ser space
@e-kotov
exclude md5 files when listing java distribs
5ca867e
@e-kotov
unlink md5 files along with distribs
ac1fdbb
@e-kotov
more param name cleanups
d4c6b49
@e-kotov
Merge branch 'main' into 2024-08-19-cran-resubmittion
af760f0
@e-kotov
implement option for cache folder
4eaeaa3
@e-kotov
Merge pull request #43 from e-kotov/2024-08-20-cran-resubmission
188a4ce 
implement option for cache folder
@e-kotov
fix project path handling and printing in java_env_set
4caddb4
@e-kotov
fix infor regarding the cache path setting in consent boilerplate
4c511aa
@e-kotov
fix cache path output for windows in consent
87ff73e
@e-kotov
fix bug with nested symlinks on macOS and linux on repeat java_instal…
256d15d 
…l runs
@e-kotov
minor improvements in listing installed java in project dir
569852b
@e-kotov
create global quiet param help and switch completely to quiet instead…
933e7e0 
… of verbose
@e-kotov
fix typo in quiet argument in java_install
1cc5d3a
@e-kotov
fix vignettes for pkgdown
4776438
@e-kotov
remove rjavaenv folder completely on delte_all=TRUE
32031dd
@e-kotov
update quick start vignette
8cc22fe
@e-kotov
update the detailed vignette
3145382
@e-kotov
cleanup user names
ba4c02d
@e-kotov
fix copy recursion bug
2db0a94
@e-kotov
fix wording about windows junctions
8d003cf
@e-kotov
improve docs, examples and messaging
17c2de9
@e-kotov
fix temp dir behaviour
9c91a47
@e-kotov
safer examples with tempdir
5051e1a
@e-kotov
fix cache detection
0072f45
@e-kotov
fix example in java_install
6aba6ab
@e-kotov
java 17 in quick install example
c6d4218
@e-kotov
update package metadata
7983e30
@e-kotov e-kotov merged commit bc203d9 into main Aug 20, 2024
7 checks passed
@e-kotov e-kotov deleted the 2024-08-19-cran-resubmission branch August 20, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@e-kotov