Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update package dependencies #79

Merged
merged 3 commits into from
May 20, 2020
Merged

update package dependencies #79

merged 3 commits into from
May 20, 2020

Conversation

SimonLab
Copy link
Member

ref: #76

@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label May 20, 2020
@SimonLab SimonLab self-assigned this May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020 •
edited
Loading

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          210       210           
=========================================
  Hits           210       210
Impacted Files Coverage Δ
lib/auth_web/controllers/auth_controller.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43475a...833db09. Read the comment docs.

@SimonLab SimonLab requested a review from nelsonic May 20, 2020 14:47
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab May 20, 2020
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed in-progress An issue or pull request that is being worked on by the assigned person and removed in-progress An issue or pull request that is being worked on by the assigned person awaiting-review An issue or pull request that needs to be reviewed labels May 20, 2020
@SimonLab SimonLab assigned SimonLab and unassigned nelsonic May 20, 2020
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab May 20, 2020
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels May 20, 2020
nelsonic
nelsonic approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab update looks great. thanks! 👍

@nelsonic nelsonic merged commit 42121b1 into master May 20, 2020
@nelsonic nelsonic deleted the update-deps-#76 branch May 20, 2020 16:20
@nelsonic nelsonic mentioned this pull request May 20, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonLab @nelsonic