Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update All Dependencies (Phoneix, Ecto, Fields, etc.) #76

Closed
4 tasks done
nelsonic opened this issue May 14, 2020 · 6 comments
Closed
4 tasks done

Update All Dependencies (Phoneix, Ecto, Fields, etc.) #76

nelsonic opened this issue May 14, 2020 · 6 comments
Assignees
@SimonLab
Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented May 14, 2020 •
edited
Loading

Now that #43 and #75 are merged, we can update the dependencies to latest versions.

Todo

  • Consult the list of dependencies that have updates on https://libraries.io/hex/auth
    image
  • Update all dependencies and any necessary code.
  • Create Pull Request
  • Publish new version of auth to Hex.pm so that the badge will reflect the update.

We should do this update after dwyl/phoenix-chat-example#38 so we get some practice.
The reason we create examples is so that we can get practice with our craft/tools.
It also serves as a more generic intro to a given topic (e.g. Learning Phoenix) that members of the extended Elixir community can benefit from. In general, I find that once I've done an upgrade to one project it's easier to replicate it the second time.
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! T1h Time Estimate 1 Hour chore a tedious but necessary task often paying technical debt technical A technical issue that requires understanding of the code, infrastructure or dependencies labels May 14, 2020
@nelsonic nelsonic added the priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished label May 18, 2020
@nelsonic
Copy link
Member Author

Added P2 because I feel that we really want to keep this up-to-date to show it's maintained. 💭

@SimonLab SimonLab self-assigned this May 20, 2020
@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label May 20, 2020
SimonLab added a commit that referenced this issue May 20, 2020
@SimonLab
update package dependencies, #76
af324fe
@SimonLab SimonLab mentioned this issue May 20, 2020
Merged
SimonLab added a commit that referenced this issue May 20, 2020
@SimonLab
use @inner_content, #76
65d06ff
@SimonLab
Copy link
Member

Following the upgrade guide for Phoenix 1.5: https://gist.github.com/chrismccord/e53e79ef8b34adf5d8122a47db44d22f

SimonLab added a commit that referenced this issue May 20, 2020
@SimonLab
update package version to 1.2.2, #76
833db09
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels May 20, 2020
@nelsonic
Copy link
Member Author

@SimonLab thanks for PR #79 ✅

@nelsonic
Copy link
Member Author

Updated Package published to https://hex.pm/packages/auth/1.2.2 📦

@nelsonic
Copy link
Member Author

Waiting for Libraries.io to update ... Libraries.io dependency status ⏳

@nelsonic
Copy link
Member Author

Done. ✅
(thanks @SimonLab!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLab SimonLab

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @SimonLab