-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep inserted_at value to the original value #36
Changes from 6 commits
a76418c
6bc2aca
400fef0
530f7e0
7d46a3a
34c76da
e5b9353
c2b495e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
language: elixir | ||
elixir: | ||
- 1.7 | ||
otp_release: | ||
- 20.2.4 | ||
env: | ||
- MIX_ENV=test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't think you need this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. indeed, thanks @samhstn 👍 |
||
cache: | ||
directories: | ||
- _build | ||
- deps | ||
services: | ||
- postgresql | ||
env: | ||
global: | ||
- MIX_ENV=test | ||
before_script: | ||
- mix do ecto.create, ecto.migrate | ||
script: | ||
- mix test |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ defmodule Alog.MixProject do | |
def project do | ||
[ | ||
app: :alog, | ||
version: "0.4.2", | ||
version: "0.4.3", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should be 0.5.0 now, as we've changed the behaviour of the module There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't sure about the version. For me it's a patch fix as the API hasn't changed and I don't think this PR add a new functionality, I see keeping the
but happy to to update to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see how this could be considered a bug, but I think it changes enough that it could introduce unexpected errors into code that uses it, eg. someone could have been using I think just to be safe we should bump to |
||
elixir: "~> 1.7", | ||
elixirc_paths: elixirc_paths(Mix.env()), | ||
start_permanent: Mix.env() == :prod, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇