keep inserted_at value to the original value

[SimonLab]

ref: #30
Define inserted_at value to be the timestamp of the first item inserted

[Danwhy]

This is a good way to get the inserted_at timestamp for all items, but I'm not sure we want it to be part of the all function; making two Repo.all calls, plus mapping over the results could really slow down the query.

I feel like it would be better to override the default inserted_at timestamp when we update an item, retaining it from the last row.

We could use the code you've written here, but I think using it only once, as part of a migration script which updates the inserted_at of the most recent items would be better.

[SimonLab]

@Danwhy makes sense 👍

[SimonLab]

@Danwhy the insert function should now keep the first inserted_at value. I've also updated the functions to sort by updated_at instead of inserterd_at to make sure to get the newest item.

[Danwhy]

Looks good, just one small point

[Danwhy]

I think this should be 0.5.0 now, as we've changed the behaviour of the module

[SimonLab]

I wasn't sure about the version. For me it's a patch fix as the API hasn't changed and I don't think this PR add a new functionality, I see keeping the inserted_at value as a bug fix

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.

but happy to to update to 0.5.0 if you think the logic of the code is different 👍 , let me know what you prefer

[Danwhy]

I see how this could be considered a bug, but I think it changes enough that it could introduce unexpected errors into code that uses it, eg. someone could have been using inserted_by to get the most recent items in their database, and now that won't work the same.

I think just to be safe we should bump to 0.5.0

https://xkcd.com/1172/

[samhstn]

don't think you need this env, you've already written it below

[SimonLab]

indeed, thanks @samhstn 👍

[Danwhy]

Looks great, thanks @SimonLab

[nelsonic]

🥇

[nelsonic]

@SimonLab great work, thanks! 👍