Push domain exclusions to internal release #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f BSK PR: duckduckgo/BrowserServicesKit#918 iOS PR: duckduckgo/iOS#3164 ## Description Implements domain exclusions for internal users only.
1 task
diegoreymendez
commented
Aug 6, 2024
Comment on lines
+148
to
+153
| <Test | ||
| Identifier = "TabContentTests/testWhenPDFContextMenuPrintChosen_printDialogOpens()"> | ||
| </Test> | ||
| <Test | ||
| Identifier = "TabContentTests/testWhenPDFMainMenuPrintChosen_printDialogOpens()"> | ||
| </Test> |
There was a problem hiding this comment.
Flaky tests, there are tasks for these.
|
For clarity, just finished a self review and all looks good to me. |
|
This was already reviewed in #3045, so I'll go the route we usually take and consider this a glorified cherry-pick with CI validation. I've also tested this extensively, I'll do one more round of testing and merge if all looks good to me. |
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Aug 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1207987809385256/f BSK PR: duckduckgo/BrowserServicesKit#928 macOS PR: duckduckgo/macos-browser#3076 ## Description Integrates latest macOS BSK changes for supporting domain exclusions.
|
A flakey test is failing on UI tests, but it's not related to my changes. @SabrinaTardio mentioned she can fix it in a follow-up PR. |
1 task
graeme
added a commit
that referenced
this pull request
Oct 8, 2024
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208463834186044/f **Description**: For some weeks we've had reports about music playing after a browser window playing music is closed. Turns out an indirect reference to the WebView was being held through the `ActiveDomainPublisher` introduced during #3076. I've made an attempt at fixing this, but lemme know if there's a better way. **Steps to test this PR**: 1. Open a single browser window. 2. Go to soundcloud.com and start any music playing 3. Close the window **4. Music should stop playing** **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207987809385256/f
BSK PR: duckduckgo/BrowserServicesKit#928
iOS PR: duckduckgo/iOS#3195
Description
Implements domain exclusions for internal users only.
Testing
The tests were ordered in a way to try and make it easy to run them sequentially.
Make sure external users can't access domain exclusions
Make sure internal users can access domain exclusions through the in-app status view
Make sure internal users can access domain exclusions through settings
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation