Push domain exclusions to internal release #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… iOS. (#3164) Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f BSK PR: duckduckgo/BrowserServicesKit#918 macOS PR: duckduckgo/macos-browser#3045 ## Description Integrates latest macOS BSK changes for supporting domain exclusions.
This was referenced Aug 6, 2024
diegoreymendez
commented
Aug 6, 2024
| 9F69331B2C5A16E200CD6A5D /* OnboardingDaxFavouritesTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9F69331A2C5A16E200CD6A5D /* OnboardingDaxFavouritesTests.swift */; }; | ||
| 9F69331D2C5A191400CD6A5D /* MockTutorialSettings.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9F69331C2C5A191400CD6A5D /* MockTutorialSettings.swift */; }; | ||
| 9F6933192C59BB0300CD6A5D /* OnboardingPixelReporterMock.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9F6933182C59BB0300CD6A5D /* OnboardingPixelReporterMock.swift */; }; |
There was a problem hiding this comment.
Not sure why Xcode is moving this around, but nothing really changed.
|
This was already reviewed in #3164, so I'll go the route we usually take and consider this a glorified cherry-pick with CI validation. I've also tested this extensively, I'll do one more round of testing and merge if all looks good to me. |
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1207987809385256/f BSK PR: duckduckgo/BrowserServicesKit#928 iOS PR: duckduckgo/iOS#3195 ## Description Implements domain exclusions for internal users only.
samsymons
added a commit
that referenced
this pull request
Aug 7, 2024
# By Mariusz Śpiewak (7) and others # Via Diego Rey Mendez (1) and GitHub (1) * main: Bump BSK to 181.1.0 (sets Privacy Dashboard to 5.0.0) (#3166) Animate transition between New Tab Page and tab switcher (#3196) Fix New Tab Page UI issues on iOS 15 (#3198) Push domain exclusions to internal release (#3195) Show shortcuts for enabled features only (#3193) Translate strings introduced in New Tab Page improvements (#3174) Update release workflow to use S3 bucket name from secrets (#3120) Handle contingency settings state on remote config (#3190) Add UI for displaying Duck Player contingency message #3065 (#3181) Open keyboard on New Tab Page based on Settings (#3187) Integrated macOS VPN Domain exclusion (internal release) changes into iOS. (#3164) Release 7.132.0-0 (#3194) Increase testPixelDebouncePreventsFiringWithinInterval test timeout (#3192) Update toolbar items for New Tab Page (#3185) new pixel and parameter for monitoring clearing of data stores (#3186) ensure new data clearing api is being used (#3191) If no App Store subscriptions option are available return empty options object (#3188) Show Intro message for existing users on New Tab Page (#3173) Experiment Contextual onboarding (#3160) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207987809385256/f
BSK PR: duckduckgo/BrowserServicesKit#928
macOS PR: duckduckgo/macos-browser#3076
Description
Integrates latest macOS BSK changes for supporting domain exclusions.
Testing
Ensure the VPN works well and check that nothing is broken.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation