Contextual Onboarding - Translations #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 The Asana task linked in the PR description is not added to iOS App Board project.
|
github-actions
bot
added
the
bot: not in app board
samsymons
approved these changes
Aug 3, 2024
alessandroboron
changed the title
alessandroboron
force-pushed
the
alessandro/contextual-onboarding-translations
branch
from
c447f95 to
6949bbd
Compare
alessandroboron
merged commit c9ed474
into
AleSab/implement-contextual-onboarding
13 of 14 checks passed
alessandroboron
deleted the
alessandro/contextual-onboarding-translations
branch
alessandroboron
added a commit
that referenced
this pull request
Aug 5, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207556941490012/f **Description**: Add translations for contextual onboarding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207556941490012/f
Description:
Add translations for contextual onboarding. I had to manually fix Norwegian
.stringsDictionaryas Smartlings changes were all over the files (for no reason). Actually it amazes me how I make sure to include only my strings in the translations and then when I download the published translations there are other strings that don’t belong to my job and have to commit only certain parts of the file. I may brought it up at the next Apple weeklly. Either I’m unlucky or I’m doing something wrong. I did a smoke test of the Norwegian one and looks fine.Steps to test this PR:
Prerequisites:
VariantIOS(name: "mb", weight: 1, isIncluded: VariantIOS.When.always, features: [.newOnboardingIntro])inDefaultVariantManagerat line 145.newInstallCompletion(self)inDefaultVariantManagerat line 128.Pick some random language. Norwegian, Polish and Russian and follow the linear onboarding flow.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template