-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated macOS VPN Domain exclusion (internal release) changes into iOS. #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
diegoreymendez
changed the title
VPN Domain exclusions (internal release)
Integrated macOS VPN Domain exclusion (internal release) changes into iOS.
Jul 31, 2024
quanganhdo
approved these changes
Aug 5, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 5, 2024
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f iOS PR: duckduckgo/iOS#3164 macOS PR: duckduckgo/macos-browser#3045 What kind of version bump will this require?: Patch ## Description Adds BSK support for implements domain exclusions in macOS for internal users only.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 5, 2024
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f BSK PR: duckduckgo/BrowserServicesKit#918 iOS PR: duckduckgo/iOS#3164 ## Description Implements domain exclusions for internal users only.
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 6, 2024
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f iOS PR: duckduckgo/iOS#3164 macOS PR: duckduckgo/macos-browser#3045 What kind of version bump will this require?: Patch ## Description Adds BSK support for implements domain exclusions in macOS for internal users only.
diegoreymendez
added a commit
that referenced
this pull request
Aug 6, 2024
… iOS. (#3164) Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f BSK PR: duckduckgo/BrowserServicesKit#918 macOS PR: duckduckgo/macos-browser#3045 ## Description Integrates latest macOS BSK changes for supporting domain exclusions.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 6, 2024
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f BSK PR: duckduckgo/BrowserServicesKit#918 iOS PR: duckduckgo/iOS#3164 ## Description Implements domain exclusions for internal users only.
1 task
samsymons
added a commit
that referenced
this pull request
Aug 7, 2024
# By Mariusz Śpiewak (7) and others # Via Diego Rey Mendez (1) and GitHub (1) * main: Bump BSK to 181.1.0 (sets Privacy Dashboard to 5.0.0) (#3166) Animate transition between New Tab Page and tab switcher (#3196) Fix New Tab Page UI issues on iOS 15 (#3198) Push domain exclusions to internal release (#3195) Show shortcuts for enabled features only (#3193) Translate strings introduced in New Tab Page improvements (#3174) Update release workflow to use S3 bucket name from secrets (#3120) Handle contingency settings state on remote config (#3190) Add UI for displaying Duck Player contingency message #3065 (#3181) Open keyboard on New Tab Page based on Settings (#3187) Integrated macOS VPN Domain exclusion (internal release) changes into iOS. (#3164) Release 7.132.0-0 (#3194) Increase testPixelDebouncePreventsFiringWithinInterval test timeout (#3192) Update toolbar items for New Tab Page (#3185) new pixel and parameter for monitoring clearing of data stores (#3186) ensure new data clearing api is being used (#3191) If no App Store subscriptions option are available return empty options object (#3188) Show Intro message for existing users on New Tab Page (#3173) Experiment Contextual onboarding (#3160) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f
BSK PR: duckduckgo/BrowserServicesKit#918
macOS PR: duckduckgo/macos-browser#3045
Description
Integrates latest macOS BSK changes for supporting domain exclusions.
Testing
Ensure the VPN works well and check that nothing is broken.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation