Add note about Danger matching rules #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loremattei
force-pushed
the
loremattei/add-note-for-tds-privacy
branch
from
18e1dcb to
042648b
Compare
ayoy
reviewed
Oct 12, 2023
scripts/update_embedded.sh
Outdated
| @@ -60,5 +60,6 @@ performUpdate() { | |||
| rm -f "$TEMP_ETAG_FILENAME" | |||
| } | |||
|
|
|||
| # The following URLs shall match the ones in AppURLs.swift. Danger checks that the URLs match on every PR. If the code changes, the regex that Danger uses may need an update. | |||
| performUpdate 'https://staticcdn.duckduckgo.com/trackerblocking/v5/current/ios-tds.json' "${base_dir}/Core/AppTrackerDataSetProvider.swift" "${base_dir}/Core/trackerData.json" | |||
| performUpdate 'https://staticcdn.duckduckgo.com/trackerblocking/config/v2/ios-config.json' "${base_dir}/Core/AppPrivacyConfigurationDataProvider.swift" "${base_dir}/Core/ios-config.json" | |||
There was a problem hiding this comment.
Whoa, at first I thought that the Danger error for this PR was a false negative, but this URL actually is different than the one in AppURLs.swift and should be updated 😳 At least we've just verified that your new Danger check works :)
There was a problem hiding this comment.
Cool!
I've updated the link and embedded files.
samsymons
added a commit
that referenced
this pull request
Oct 17, 2023
samsymons
added a commit
that referenced
this pull request
Oct 27, 2023
* develop: (28 commits) Update BSK with autofill 9.0.0 (#2103) Add an “Open VPN Settings” quick action (#2089) bump BSK (changed dashboard API) (#2111) Integrate BSK changes (#2101) bump bsk for duckplayer fixes on BigSur (#2106) iOS VPN Settings part 1 (#2109) Release 7.94.0 (#2107) Append build number to metricKit crash version (#2100) Disable NetP errors temporarily (#2102) NetP: Fix server location formatting (#2099) address bar position (#2072) Fix privacy tests (#2097) Add note about Danger matching rules (#2087) Release 7.93.0 (#2096) Release 7.93.0 (#2096) Update tabs tests (#2088) Ignore form factor specific favorites if they're received in Sync response (#2083) Update BSK with autofill 8.4.2 (#2084) Bump C-S-S to 4.39.0 (#2085) BSK hotfix 80.3.0-1 merged to the main branch (#2079) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200194497630846/1205584545360104/f
Tech Design URL:
CC:
Description: Add note about a Danger rule that checks Privacy and TDS files URL matching.
Update: It turned out we actually needed to update the embedded file URL, so I also committed that change.
** Test **
Internal references:
Software Engineering Expectations
Technical Design Template