Add note about Danger matching rules (#2087)

Co-authored-by: Lorenzo Mattei <[email protected]>
duckduckgo · Oct 15, 2023 · 1fef42a · 1fef42a
1 parent 3586115
commit 1fef42a
Show file tree

Hide file tree

Showing 4 changed files with 376 additions and 457 deletions.
diff --git a/Core/AppPrivacyConfigurationDataProvider.swift b/Core/AppPrivacyConfigurationDataProvider.swift
@@ -23,8 +23,8 @@ import BrowserServicesKit
 final public class AppPrivacyConfigurationDataProvider: EmbeddedDataProvider {
 
     public struct Constants {
-        public static let embeddedDataETag = "\"54efb258435567856e087913f93d43df\""
-        public static let embeddedDataSHA = "d0f9c70c5baba23a0966b277f8b4c949ecf01612558a50d2bda720fe1919b43f"
+        public static let embeddedDataETag = "\"81da520221d37e6398ea3d8940595810\""
+        public static let embeddedDataSHA = "19766ed7e598cdc123c9db702264b99d0cff5ddfb2ed226fba85b06d304f7e0b"
     }
 
     public var embeddedDataEtag: String {

diff --git a/Core/AppURLs.swift b/Core/AppURLs.swift
@@ -33,6 +33,9 @@ public extension URL {
     static let aboutLink = URL(string: AppDeepLinkSchemes.quickLink.appending("\(ddg.host!)/about"))!
 
     static let surrogates = URL(string: "\(staticBase)/surrogates.txt")!
+
+    // The following URLs shall match the ones in update_embedded.sh. 
+    // Danger checks that the URLs match on every PR. If the code changes, the regex that Danger uses may need an update.
     static let privacyConfig = URL(string: "\(staticBase)/trackerblocking/config/v3/ios-config.json")!
     static let trackerDataSet = URL(string: "\(staticBase)/trackerblocking/v5/current/ios-tds.json")!
     static let bloomFilter = URL(string: "\(staticBase)/https/https-mobile-v2-bloom.bin")!