Update BSK with NetP auth changes #2077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Oct 8, 2023
Comment on lines
13
to
14
| /* The body of the notification shown when Network Protection connects successfully with the city + state/country as formatted parameter */ | ||
| "network.protection.success.notification.subtitle.including.serverLocation" = "Routing device traffic through \(serverLocation)."; |
There was a problem hiding this comment.
@graeme I noticed this appearing after building, presumably as the user text build phase step runs - committing the change here even though it isn't directly related to this PR.
6 tasks
graeme
reviewed
Oct 13, 2023
graeme
approved these changes
Oct 13, 2023
# By Graeme Arthur (14) and others # Via Graeme Arthur (7) and others * develop: (87 commits) NetP waitlist (#2160) NetP VPN locations screen (#2183) bump bsk for CBR energy usage (#2195) Fix sync Form Factor specific favorites tests (#2164) Release 7.98.0 (#2193) Update BSK ref to latest one (#2191) Release 7.97.1 (#2190) Revert "Breakage report improvements" (#2189) Breakage report improvements (#2168) bump C-S-S to 4.52.0 (#2186) Revert "refactor bookmarks and fire pixel if migration happens more than once" refactor bookmarks and fire pixel if migration happens more than once Release 7.98.0 (#2179) Bump autoconsent to 6.4.0 (#2174) remove redundant orientation detection (#2178) Removed unarchiveTopLevelObjectWithData deprecation (#2176) fix pass kit related crash on iPad (#2171) Update email protection e2e test to match the new UI (#2170) Updates BSK (#2173) Rolls back a BSK change by mistake ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift # PacketTunnelProvider/en.lproj/Localizable.strings
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 25, 2023
Required: Task/Issue URL: https://app.asana.com/0/0/1205645389501250/f iOS PR: duckduckgo/iOS#2077 macOS PR: duckduckgo/macos-browser#1710 What kind of version bump will this require?: Major Description: This PR adds support for exchanging access tokens for auth tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205645389501250/f
Tech Design URL:
CC:
Description:
This PR updates NetP with auth changes.
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template