Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetP authorize API support #523

Merged
merged 12 commits into from
Dec 25, 2023
Merged

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Oct 4, 2023

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1205645389501250/f
iOS PR: duckduckgo/iOS#2077
macOS PR: duckduckgo/macos-browser#1710
What kind of version bump will this require?: Major

Description:

This PR adds support for exchanging access tokens for auth tokens.

Steps to test this PR:

  1. See client PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

* main:
  Pin SwiftLint to 0.53.0 (#522)
  Bump C-S-S (#498)
  Allow empty string in decrypt (#520)
  Use the metric’s applicationVersion in crash pixel params. (#515)
  Connection interruption simulation option (#516)
  Improve Asana integration for failed PR checks (#514)
  Update autofill to 8.4.1 (#517)
  Add API for stored failed compilations (#504)
  Add DDGSync lifecycle and init tests (#510)
  Add run attempt to WORKFLOW_URL for reporting failed tests (#513)
@samsymons samsymons changed the title Sam/add netp subscription auth support Add NetP authorize API support Oct 4, 2023
* main:
  Adds onByDefault subfeature to Autofill privacy feature (#519)
  Removes incrementalRolloutTest2 (#521)
  NetP connection notifications improvements (#527)
  Migrate unit tests workflow to M1 runner (#525)
This commit removes a NetworkProtectionClient mock which was in the test suite, and replaces it with the version from the test utils package.
@samsymons samsymons marked this pull request as ready for review October 8, 2023 22:07
}
}

private func redeem(inviteCode: String) async -> Result<String, NetworkProtectionClientError> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this would be a bit simpler if we just exposed these functions instead of having the enum. I feel like it would be a bit less code. Not a blocker though.

Copy link
Contributor

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but not blocking 👍

samsymons and others added 4 commits November 26, 2023 15:43
# By Dominik Kapusta (5) and others
# Via GitHub
* main: (31 commits)
  cache the calculated temporary unprotected domains property (#574)
  Merge 83.0.0-3 hotfix (#573)
  Revert "Breakage report improvements (#566)" (#572)
  Breakage report improvements (#566)
  Updating C-S-S to 4.52.0 for DBP (#568)
  Fix NetP connectivity issues. (#567)
  Autofill "Never Save for this Site"  (#555)
  Removing an exception that I think was merged by mistake (#563)
  BSK changes for NetP iOS Geoswitching (#557)
  Fix timing issues with tracker surrogate injection (#558)
  Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#559)
  Sync form factor specific favorites (#511)
  Add selected environment preference (#544)
  Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests from `2e73221` to `7519c3d` (#556)
  Add DBP feature (#551)
  Add a check for the DAU pixel when the bandwidth analyzer runs a test. (#553)
  Fix syncing empty favorites folders (#546)
  Alert user about abnormal app conditions (#539)
  Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#543)
  NetP iOS notifications settings (#541)
  ...

# Conflicts:
#	Sources/NetworkProtection/Networking/NetworkProtectionClient.swift
#	Sources/NetworkProtectionTestUtils/Networking/MockNetworkProtectionClient.swift
#	Tests/NetworkProtectionTests/NetworkProtectionDeviceManagerTests.swift
* main: (39 commits)
  Fix privacy config fetch in debug mode (#606)
  Expose Internal User managing from Config (#610)
  Add Sync feature flags (#607)
  Fix Networking import into TestUtils (#609)
  Add Sync Success Rate pixel (#605)
  Add new logger (#604)
  Prevent VPN server list persistence failures (#603)
  SwiftLint plugin (#393)
  Update autofill to 10.0.2 (#599)
  Remove the reconnect/disconnect logic from the connection tester
  Fix an IPv6 regression. (#598)
  Quality metrics for Sync (#597)
  Report NetP connection attempts, tunnel failures, and latency (#584)
  Implement deleteAccount Sync endpoint (#596)
  Ensure that LinkPresentation framework is called on main thread (#595)
  No longer excluding the 10.0.0.0/8 range (#594)
  Update autofill to 10.0.1 (#591)
  Implement deleteAccount Sync endpoint (#596)
  Ensure that LinkPresentation framework is called on main thread (#595)
  No longer excluding the 10.0.0.0/8 range (#594)
  ...
* main:
  Update latency & tunnel failure monitors implementation (#613)
  Prevents VPNSettings from reporting fake changes (#614)
  Update Link Tracking Protection to preserve headers (#600)
@samsymons samsymons merged commit c3a482a into main Dec 25, 2023
5 checks passed
@samsymons samsymons deleted the sam/add-netp-subscription-auth-support branch December 25, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants