Add parameter to multiple Autofill pixels #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amddg44
requested review from
a team and
SabrinaTardio
and removed request for
a team
13 tasks
Task/Issue URL: https://app.asana.com/0/0/1205296228305939/f Tech Design URL: CC: Description: Adds support for rolling out Autofill as on by default for new installs based on the incremental feature flag onByDefault
…l-param-updates # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205431733474502/f
Tech Design URL:
CC:
Description:
Adding a temporary "default state" parameter to some autofill pixels ahead of Autofill becoming "on by default"
Steps to test this PR:
Note: the parameter will currently always be
offsince Autofill is currently off by default for all users. The logic to make this dynamic will be based on a phased rollout remote feature will be tackled in another PR.Also, https://fill.dev/ is a useful site for testing
["default_state": "off"]Prompt to disable setting:
To test this, start with a clean install and Autofill enabled. Visit 3 different websites that have a login option and attempt to login to each. For each Save Prompt choose "Not Now". After the 3rd "Not Now" you'll be presented with the alert that fires these pixels:
m_autofill_logins_save_disable-prompt_shownm_autofill_logins_save_disable-prompt_autofill-keptm_autofill_logins_save_disable-prompt_autofill-disabledSave login prompt:
m_autofill_logins_save_login_inline_displayedm_autofill_logins_save_login_inline_confirmedm_autofill_logins_save_login_inline_dismissedSave password prompt:
(https://news.ycombinator.com/login is a useful site to test triggering the password only save prompt - in the login form enter only a password and tap login to trigger)
m_autofill_logins_save_password_inline_displayedm_autofill_logins_save_password_inline_confirmedm_autofill_logins_save_password_inline_dismissedFill login prompt:
m_autofill_logins_fill_login_inline_manual_displayedm_autofill_logins_fill_login_inline_manual_confirmedm_autofill_logins_fill_login_inline_manual_dismissedm_autofill_logins_fill_login_inline_autoprompt_displayedm_autofill_logins_fill_login_inline_autoprompt_confirmedm_autofill_logins_autoprompt_dismissedOpening and toggling autofill logins setting:
m_autofill_settings_opened(Triggered by accessing Logins from Settings screen)m_nav_autofill_menu_item_pressed(Triggered by accessing Logins from browsing menu)m_autofill_logins_settings_enabledm_autofill_logins_settings_disabledPassword generation prompts:
m_autofill_logins_password_generation_prompt_displayedm_autofill_logins_password_generation_prompt_confirmedm_autofill_logins_password_generation_prompt_dismissedInternal references:
Software Engineering Expectations
Technical Design Template