Autofill onByDefault rollout for new installs #2056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205296228305939/f
Tech Design URL:
CC:
Description:
Adds support for rolling out Autofill as on by default for new installs based on the incremental feature flag
onByDefault
Steps to test this PR:
Notes:
This PR branches off of #2032 which added a pixel parameter reporting the "on by default" state.
The rules for enabling Autofill as on by default are:
onByDefault
must enable the feature for themdevelop
and confirm that Autofill is off by defaultios-config.json
adding theonByDefault
subfeature to theautofill
json (see https://app.asana.com/0/0/1205590415076770/f)AppURLs
change the privacyConfig URL to anything else so the config isn't overwritten from the server e.g.static let privacyConfig = URL(string: "\(staticBase)/trackerblocking/config/v3/ios-config-invalid.json")!
["default_state": "off"]
ios-config.json
steps and add rollout at 100% like so:off
by default (as reported by the pixel parameter)off
(as reported by the pixel parameter)ios-config.json
to Step 3off
on
by defaultCopy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template