Add WireGuard NetP Error Pixels #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Task/Issue URL: https://app.asana.com/0/0/1205518995339760/f BSK PR: duckduckgo/BrowserServicesKit#505 macOS PR: duckduckgo/macos-browser#1631 ## Description Integrates the latest BSK changes.
Task/Issue URL: https://app.asana.com/0/1205538042573900/1205538042573900 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/8.4.0 BSK PR: duckduckgo/BrowserServicesKit#509 Description Updates Autofill to version 8.4.0.
Task/Issue URL: https://app.asana.com/0/1203137811378537/1204886111391108/f ## Description Implements on-demand through always-on. This feature is disabled by default and needs to be enabled in Network Protection's debug settings menu.
samsymons
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205524329218224/f
Description:
When implementing error pixels for NetP on iOS, I noticed that macOS was missing the Pixels (that were listed in its privacy triage) for WireGuard error callbacks. Furthermore, we didn’t have the hook to respond to them from the NetworkProtection library. This task adds this capability so we can get a better idea of why WireGuard is failing in the wild.
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template