-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WireGuard NetP Error Pixels #508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
reviewed
Sep 21, 2023
// This is probably not the most elegant error to show to a user but | ||
// it's a great way to get detailed reports for those cases we haven't | ||
// provided good descriptions for yet. | ||
return "NetworkProtectionError.\(String(describing: self))" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Sounds fair to me
samsymons
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1205524329218224/f
iOS PR: duckduckgo/iOS#2023
macOS PR: duckduckgo/macos-browser#1641
What kind of version bump will this require?: Major/Minor/Patch
Description:
When implementing error pixels for NetP on iOS, I noticed that macOS was missing the Pixels (that were listed in its privacy triage) for WireGuard error callbacks. Furthermore, we didn’t have the hook to respond to them from the NetworkProtection library. This task adds this capability so we can get a better idea of why WireGuard is failing in the wild.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template