-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Kotlin 2.1.0-Beta2 in CI #411
Conversation
132bb0d
to
7edbc63
Compare
7edbc63
to
05b6e0d
Compare
Co-authored-by: Jake Wharton <[email protected]>
This is thrown with 2.1.0-Beta2. I think this means we just won't be able to make 2.1 and 2.0 compatible, much like 2.0 and 1.9. Unless there's some Gradle magic we can do? |
That stack trace is weird. Isn't it KGP calling into itself that is causing the exception? Are there two KGPs on the Gradle classpath or something? |
This code: Poko/sample/settings.gradle.kts Lines 76 to 84 in 4e710fe
Needs to also live here: Poko/sample/buildSrc/settings.gradle.kts Lines 3 to 5 in 4e710fe
Otherwise the |
I can send a PR for that later, if you don't get to it first. |
Ouch. Good find, fixed. |
05288fd
to
0ad5384
Compare
0ad5384
to
f69fe92
Compare
The fix that Jake found in #411 may result in these tests passing now.
* Re-add sample tests against 2.0.0 and 2.0.10 The fix that Jake found in #411 may result in these tests passing now. * Fix support for 2.0.0 consumers
Tests compatibility of current Poko main branch with the new Kotlin beta version.