Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 2.1.0 support #403

Closed
3flex opened this issue Sep 20, 2024 · 5 comments · Fixed by #425
Closed

Kotlin 2.1.0 support #403

3flex opened this issue Sep 20, 2024 · 5 comments · Fixed by #425

Comments

@3flex
Copy link
Contributor

3flex commented Sep 20, 2024

I'm seeing errors with Kotlin 2.1.0-Beta1:

Caused by: java.lang.NoSuchMethodError: 'org.jetbrains.kotlin.fir.types.ConeKotlinType org.jetbrains.kotlin.fir.types.FirResolvedTypeRef.getType()'
	at dev.drewhamilton.poko.fir.PokoFirExtensionSessionComponent.classId(PokoFirExtensionSessionComponent.kt:39)
	at dev.drewhamilton.poko.fir.PokoFirExtensionSessionComponent.pokoAnnotation(PokoFirExtensionSessionComponent.kt:19)
	at dev.drewhamilton.poko.fir.PokoFirCheckersExtension$PokoFirRegularClassChecker.check(PokoFirCheckersExtension.kt:45)
	at dev.drewhamilton.poko.fir.PokoFirCheckersExtension$PokoFirRegularClassChecker.check(PokoFirCheckersExtension.kt:36)
This was referenced Sep 20, 2024
@drewhamilton
Copy link
Owner

Easiest way to demonstrate this going forward is to add a variant to the build-sample CI job, as in the first commit of #411. Then we can try to use reflection to make the current version forward-compatible with upcoming betas.

@drewhamilton
Copy link
Owner

2.1.0-Beta2 is supported in the latest snapshot.

@3flex
Copy link
Contributor Author

3flex commented Oct 18, 2024

I'm not asking for an alpha release, I know there's effort involved, but just an FYI this is currently not convenient to test in our build (without a fair bit of refactoring) due to the need to add the snapshot repo all over the place in our tests because of #328, so I can't verify locally.

I was going to revisit that issue to see what's changed in recent Kotlin releases but haven't had the time.

@drewhamilton
Copy link
Owner

I can do a dot release since it's still compiled with 2.0.21. I'll plan on doing that today.

@drewhamilton
Copy link
Owner

0.17.2 supports 2.0.0 – 2.1.0-Beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants