Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always set GTF_GLOB_REF on block indirs #84731

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Always set GTF_GLOB_REF on block indirs #84731

merged 1 commit into from
Apr 13, 2023

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Apr 12, 2023 •
edited
Loading

Eventually, this logic will be shared by all indirs.

No diffs.

@SingleAccretion
Always set GTF_GLOB_REF on block indirs
91890a1 
Eventually, this logic will be shared by all indirs.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 12, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 12, 2023
@ghost
Copy link

ghost commented Apr 12, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Eventually, this logic will be shared by all indirs.

No diffs are expected.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@SingleAccretion
Copy link
Contributor Author

Formatting failure is #84780.

No diffs.

@dotnet/jit-contrib

@SingleAccretion SingleAccretion marked this pull request as ready for review April 13, 2023 15:43
@build-analysis build-analysis bot mentioned this pull request Apr 13, 2023
Closed
EgorBo
EgorBo approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EgorBo EgorBo merged commit 926062a into dotnet:main Apr 13, 2023
@SingleAccretion SingleAccretion deleted the Blk-Glob-Ref branch April 19, 2023 20:25
@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SingleAccretion @EgorBo