Skip to content

Commit

Permalink
Always set GTF_GLOB_REF on block indirs (#84731)
Browse files Browse the repository at this point in the history
Eventually, this logic will be shared by all indirs.
  • Loading branch information
SingleAccretion authored Apr 13, 2023
1 parent d83e2cc commit 926062a
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions src/coreclr/jit/compiler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1196,16 +1196,7 @@ inline GenTreeBlk* Compiler::gtNewBlkIndir(ClassLayout* layout, GenTree* addr, G
blkNode->gtFlags |= indirFlags;
blkNode->SetIndirExceptionFlags(this);

// TODO-Bug: this method does not have enough information to make this determination.
// The local may end up (or already is) address-exposed.
if (addr->OperIs(GT_LCL_ADDR))
{
if (lvaIsImplicitByRefLocal(addr->AsLclVarCommon()->GetLclNum()))
{
blkNode->gtFlags |= GTF_GLOB_REF;
}
}
else
if ((indirFlags & GTF_IND_INVARIANT) == 0)
{
blkNode->gtFlags |= GTF_GLOB_REF;
}
Expand Down

0 comments on commit 926062a

Please sign in to comment.