Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change assertion in IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet #110070

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Nov 22, 2024

Contributes to #109280. Given that we don't seem to understand the reason the value is localdomain, this change feels like a test hack instead of an actual fix, thus the ActiveIssue link. If we don't care that much, I'm happy to delete the comment and close the issue.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Assert.Equal(string.Empty, gp.DomainName);

// [ActiveIssue("https://github.com/dotnet/runtime/issues/109280")]
string expectedDomainName = PlatformDetection.IsAndroid ? "localdomain" : string.Empty;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we re4ally need the comment but I'm OK keeping it.

This comment was marked as outdated.

1 similar comment

This comment was marked as outdated.

@antonfirsov

This comment was marked as outdated.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov
Copy link
Member Author

Outerloop failures are unrelated.

@antonfirsov antonfirsov merged commit d6be630 into dotnet:main Dec 9, 2024
83 of 88 checks passed
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
…henNotSet (dotnet#110070)

Accept "localdomain" as a valid DomainName on Android.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants