Skip to content

Commit

Permalink
Change assertion in IPGlobalProperties_DomainName_ReturnsEmptyStringW…
Browse files Browse the repository at this point in the history
…henNotSet (dotnet#110070)

Accept "localdomain" as a valid DomainName on Android.
  • Loading branch information
antonfirsov authored and hez2010 committed Dec 14, 2024
1 parent df70878 commit 6ade56a
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,10 @@ public async Task GetUnicastAddresses_NotEmpty()
public void IPGlobalProperties_DomainName_ReturnsEmptyStringWhenNotSet()
{
IPGlobalProperties gp = IPGlobalProperties.GetIPGlobalProperties();
Assert.Equal(string.Empty, gp.DomainName);

// [ActiveIssue("https://github.com/dotnet/runtime/issues/109280")]
string expectedDomainName = PlatformDetection.IsAndroid ? "localdomain" : string.Empty;
Assert.Equal(expectedDomainName, gp.DomainName);
}
}
}

0 comments on commit 6ade56a

Please sign in to comment.