Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for test SDK issue Microsoft/vstest#373 #23253

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Workaround for test SDK issue Microsoft/vstest#373 #23253

merged 1 commit into from
Nov 17, 2017

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 17, 2017 •
edited
Loading

Fixes lack of source information in Xunit stack traces.

Use a private build of test SDK that provides a fix.

@tmat
Copy link
Member Author

tmat commented Nov 17, 2017

@jcouv FYI

@tmat tmat changed the title Workaround for test SDK issue #Microsoft/vstest/issues/373 Workaround for test SDK issue Microsoft/vstest#373 Nov 17, 2017
@jcouv
Copy link
Member

jcouv commented Nov 17, 2017

Could you file a follow-up issue so that we don't forget to switch to non-private bits when available?

Also, are you sure this is for master branch? I'm nervous about the dependency on unreleased/future bits, as it may impact build-from-source.

@tmat tmat changed the base branch from master to post-dev15.5-contrib November 17, 2017 18:49
@tmat
Copy link
Member Author

tmat commented Nov 17, 2017

@jcouv Meant to be post-dev15.5

@tmat
Copy link
Member Author

tmat commented Nov 17, 2017

Moving back to master per @jasonmalinowski's email

@tmat tmat changed the base branch from post-dev15.5-contrib to master November 17, 2017 18:50
@tmat tmat mentioned this pull request Nov 17, 2017
Open
@tmat
Copy link
Member Author

tmat commented Nov 17, 2017

@jcouv #23254

jasonmalinowski
jasonmalinowski reviewed Nov 17, 2017
View reviewed changes
build/Targets/Packages.props
@@ -47,7 +47,8 @@
<MicrosoftInternalVisualStudioShellInterop140DesignTimeVersion>14.3.25407-alpha</MicrosoftInternalVisualStudioShellInterop140DesignTimeVersion>
<MicrosoftMetadataVisualizerVersion>1.0.0-beta1-61531-03</MicrosoftMetadataVisualizerVersion>
<MicrosoftMSXMLVersion>8.0.0.0-alpha</MicrosoftMSXMLVersion>
<MicrosoftNETTestSdkVersion>15.3.0</MicrosoftNETTestSdkVersion>
<!-- Using a private build of Microsoft.Net.Test.SDK to work around issue https://github.com/Microsoft/vstest/issues/373 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point to branch or something that you used to produce the private build? Otherwise this might give the source build effort a problem. 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's from PR: microsoft/vstest#1301, it hasn't been merged yet.

Copy link
Member Author

@tmat tmat Nov 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to be temporary workaround to make testing experience better immediately, rather than wait for a new test SDK build to show up (I'll indeed push on making that happen asap).

@tmat
Copy link
Member Author

tmat commented Nov 17, 2017

test windows_debug_vs-integration_prtest please

@jcouv
Copy link
Member

jcouv commented Nov 17, 2017

Taking @jaredpar to confirm OK with build from source.

@tmat tmat merged commit 9bbf8cd into dotnet:master Nov 17, 2017
@tmat tmat deleted the FixTestSdk branch November 17, 2017 21:21
@jcouv
Copy link
Member

jcouv commented Dec 7, 2017 •
edited
Loading

@tmat What version should I expect this fix to appear in? I still see the problem in 15.6 preview 1.

Microsoft Visual Studio Enterprise 2017 Int Preview
Version 15.6.0 Preview 1.0 [27129.0.d15.6]
VisualStudio.15.IntPreview/15.6.0-pre.1.0+27129.0.d15.6

image

@jcouv
Copy link
Member

jcouv commented Dec 15, 2017

I'm still seeing this problem in Version 15.6.0 Preview 2.0 [27213.2.d15.6].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

@jaredpar jaredpar jaredpar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmat @jcouv @jaredpar @jasonmalinowski