Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up: update to newer Microsoft.NET.Test.Sdk once https://github.com/Microsoft/vstest/issues/373 is fixed #23254

Open
tmat opened this issue Nov 17, 2017 · 6 comments
Labels
Area-Infrastructure Test Test failures in roslyn-CI
Milestone

Comments

@tmat
Copy link
Member

tmat commented Nov 17, 2017

See #23253

@tmat tmat added this to the Unknown milestone Nov 17, 2017
@tmat tmat added the Test Test failures in roslyn-CI label Nov 17, 2017
@jcouv
Copy link
Member

jcouv commented Dec 15, 2017

@tmat I'm still not getting source locations in unittest stacktraces (as shown below), even after the workaround you checked in. I'm using Version 15.6.0 Preview 2.0 [27213.2.d15.6].

image

@jcouv
Copy link
Member

jcouv commented Feb 25, 2018

Adding note to document current workaround to display line numbers in stacktraces:

  1. Install 4.7.2
  2. Modify "C:\Windows\Microsoft.NET\Framework\v4.0.30319\Config\machine.config" to add the AppContextSwitchOverrides flag:
  <runtime>
     <AppContextSwitchOverrides value="Switch.System.Diagnostics.IgnorePortablePDBsInStackTraces=false" />
  </runtime>
 
  <connectionStrings>
    ...

@tmat Where does the plan stand (short-term and long-term) to avoid this pain?

@tmat
Copy link
Member Author

tmat commented Feb 25, 2018

@noahfalk

@tmat
Copy link
Member Author

tmat commented Feb 25, 2018

At this point I think we should follow up with XUnit, NUnit and mstest to add this flag to their respective App.config files.

@jcouv
Copy link
Member

jcouv commented Feb 17, 2019

I'm not sure where we're at with this issue. microsoft/vstest#373 was closed.
While working on Roslyn, I've not experienced the problem in a while, but that may be due to a workaround that Tomas put in place.

@tmat Could you confirm the current status and update the issue title accordingly? Or maybe this can be closed now? Thanks

@tmat
Copy link
Member Author

tmat commented Feb 18, 2019

There are still issues with the latest test SDK. We need to stay on the custom package for now. E.g. microsoft/vstest#1764, microsoft/vstest#1907, microsoft/vstest#792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Test Test failures in roslyn-CI
Projects
Development

No branches or pull requests

3 participants