fix: remove history generic #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 77.71% 76.67% -1.04%
==========================================
Files 6 6
Lines 332 343 +11
Branches 73 78 +5
==========================================
+ Hits 258 263 +5
- Misses 50 53 +3
- Partials 24 27 +3 ☔ View full report in Codecov by Sentry. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This pull request updates the handling of undefined properties during the compare call.
What changed?
The README documentation and the
formatGit2Jsonfunction ingit2json.tshave been updated. TheformatGit2Jsonfunction no longer accepts a generic parameter.How to test?
Ensure the library behaves as expected when dealing with undefined properties during the compare call. Unit tests should confirm this behavior.
Why make this change?
There was an inconsistency in how undefined properties were handled during the compare call as documented in the README. This update makes the operation clearer and resolves potential issues.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: